Added better error handling for the gRPC server. #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittaakos
force-pushed
the
daemon-exit-code
branch
from
894406e to
847edc3
Compare
masci
suggested changes
Feb 21, 2020
cli/daemon/daemon.go
Outdated
| // Invalid port, such as "Foo" | ||
| var dnsError *net.DNSError | ||
| if errors.As(err, &dnsError) { | ||
| logrus.Errorf("Failed to listen on TCP port: %s. %s is unknown name.", port, dnsError.Name) |
There was a problem hiding this comment.
can we do feedback.Errorf instead? This way the error will be always visible in the shell, not regarding of passing -v and will be added to the logs as well. Same for other occurrences of logrus.*
There was a problem hiding this comment.
Thank you for the feedback. I have made the changes based on your request and left the original logrus.Fatalf("failed to serve: %v", err) as is.
- Consumers of the CLI have a better exit code when it fails at startup - Logged message to stdout, so gRPC clients know, it is time to connect Signed-off-by: Akos Kitta <[email protected]>
kittaakos
force-pushed
the
daemon-exit-code
branch
from
847edc3 to
dfafb49
Compare
masci
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akos Kitta [email protected]